canonical / microk8s.io

Code for the microk8s.io website by Canonical
https://microk8s.io
18 stars 63 forks source link

Add unit tests and clean up code #616

Closed mtruj013 closed 1 year ago

mtruj013 commented 1 year ago

Done

NOT TO BE MERGED UNTIL TUESDAY OR IT WILL KILL THE DEMO THAT IS CURRENTLY IN REVIEW WITH STAKEHOLDERS

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-6000

webteam-app commented 1 year ago

Demo starting at https://microk8s-io-616.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #616 (e88fd03) into microk8s-refresh (cf158d8) will increase coverage by 11.20%. Report is 1 commits behind head on microk8s-refresh. The diff coverage is 100.00%.

:exclamation: Current head e88fd03 differs from pull request most recent head 1792d51. Consider uploading reports for the commit 1792d51 to get more accurate results

@@                  Coverage Diff                  @@
##           microk8s-refresh     #616       +/-   ##
=====================================================
+ Coverage             72.58%   83.78%   +11.20%     
=====================================================
  Files                     2        2               
  Lines                    62       74       +12     
=====================================================
+ Hits                     45       62       +17     
+ Misses                   17       12        -5     
Flag Coverage Δ
python 83.78% <100.00%> (+11.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tests/test_routes.py 95.83% <100.00%> (+4.16%) :arrow_up:

... and 1 file with indirect coverage changes