canonical / microk8s.io

Code for the microk8s.io website by Canonical
https://microk8s.io
18 stars 63 forks source link

/resources - Add thumbnails, embed videos #625

Closed mtruj013 closed 10 months ago

mtruj013 commented 11 months ago

Done

QA

Issue / Card

Fixes # https://warthogs.atlassian.net/browse/WD-6355

webteam-app commented 11 months ago

Demo starting at https://microk8s-io-625.demos.haus

codecov[bot] commented 11 months ago

Codecov Report

Merging #625 (bdabfef) into main (bd7e018) will not change coverage. Report is 8 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head bdabfef differs from pull request most recent head e418fb8. Consider uploading reports for the commit e418fb8 to get more accurate results

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files           2        2           
  Lines          74       74           
=======================================
  Hits           62       62           
  Misses         12       12           
Flag Coverage Δ
python 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

juanruitina commented 10 months ago

I'd suggest one minor change: the thumbnail for the second to last video ("Self-healing Kubernetes at the edge: MicroK8s, Raspberry Pis and Portainer") does not really reflect the content of the video, may I ask you to switch it to the default thumbnail? Other than that, this is good enough UX-wise; feel free to change to UX+1 once you fix that.