Embbed 'how to install openstack' video in homepage

canonical / microstack.run

Code for the microstack.run website by Canonical.

https://microstack.run

4 stars 22 forks source link

Embbed 'how to install openstack' video in homepage #242

Closed petesfrench closed 1 year ago

petesfrench commented 1 year ago

Done

Embbed 'how to install openstack' video in homepage based on copydoc

QA

Check out this feature branch
Run the site using the command ./run serve
View the site locally in your web browser at: http://0.0.0.0:8039/
Run through the following QA steps
[List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-6019

webteam-app commented 1 year ago

Demo starting at https://microstack-run-242.demos.haus

codecov[bot] commented 1 year ago

Codecov Report

Merging #242 (501ccce) into main (f82a360) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head 501ccce differs from pull request most recent head 1f8a917. Consider uploading reports for the commit 1f8a917 to get more accurate results

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files           2        2           
  Lines          44       44           
=======================================
  Hits           34       34           
  Misses         10       10

Flag	Coverage Δ
python	`77.27% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

petesfrench commented 1 year ago

@mtruj013 sure thing, what is the issue with the suru?

mtruj013 commented 1 year ago

@petesfrench it's supposed to be black, not orange, like so https://web.archive.org/web/20230804084639/https://microstack.run/

Or at least that was the case when revamped this a couple months ago for the sunbeam launch. Tagging @julpal7 to confirm just in case

petesfrench commented 1 year ago

Not sure when it got reverted, but it has been orange on live for a long time now.

Anyway, I have updated it back to the black theme, do you want to take one last look @mtruj013 ?

mtruj013 commented 1 year ago

Not sure when it got reverted, but it has been orange on live for a long time now.

I think it's cause of how surus are built in Vanilla 4. At least that's my guess since the same thing happened on microk8s when we bumped the version

Anyways, LGTM!

petesfrench commented 1 year ago

@mtruj013 That makes sense, thanks for the info. Will keep an eye out for it on other sites.