canonical / minio-operator

MinIO Operator
Apache License 2.0
2 stars 11 forks source link

`minio-service` added for Charmed Kubeflow 1.8 should be moved to kfp-api to avoid bugs with deploying multiple minios at once #153

Closed ca-scribner closed 10 months ago

ca-scribner commented 10 months ago

Bug Description

[the minio-service added to minio charm to fix an upstream kfp bug]

while prepping for the KF 1.8 release, minio-operator 151 added a new service called minio-service to the minio charm. This service was added because upstream kubeflow pipelines has an issue where it hard-codes the minio service name.

I propose we revert minio-operator 151 and instead fix the bug in kfp by adding this svc/minio-service to the kfp-api charm. The main reasons are:

In general, the minio-service is something not needed by minio, just to fix a kfp bug, so it doesn't feel right imo to put it in the minio charm

To Reproduce

-

Environment

-

Relevant Log Output

-

Additional Context

No response

NohaIhab commented 10 months ago

closed by https://github.com/canonical/minio-operator/pull/154 and https://github.com/canonical/kfp-operators/pull/387 Issue https://github.com/canonical/kfp-operators/issues/389 is still open to track the upstream bug