Revert "fix: explicitly apply minio-service with name (#151)"

canonical / minio-operator

MinIO Operator

Apache License 2.0

2 stars 11 forks source link

Revert "fix: explicitly apply minio-service with name (#151)" #154

Closed ca-scribner closed 10 months ago

ca-scribner commented 10 months ago

This reverts commit b99aad877107c8023b981fe06e945a51f2622362 as described in #153. This fix is instead being moved to the kfp-api charm of kfp-operators.

DnPlas commented 10 months ago

Thanks @ca-scribner, based on https://github.com/canonical/kfp-operators/pull/387 this change makes sense. I think besides reverting this commit, we should also ensure that the service name we share in the relation data is not just the application name. We could have a var self._minio_service_name = self.app.name in case we want to change this in the future.

ca-scribner commented 10 months ago

Done. Ready for re-review