Set status to Blocked when secret-key is shorter than 8 characters long

canonical / minio-operator

MinIO Operator

Apache License 2.0

2 stars 11 forks source link

Set status to Blocked when secret-key is shorter than 8 characters long #178

Closed lucabello closed 1 month ago

lucabello commented 2 months ago

Closes https://github.com/canonical/minio-operator/issues/137.

This PR adds an additional check in the charm.py file to ensure that the secret-key is at least 8 characters long. If it isn't, the charm's status changes to blocked with an appropriate message.

The minimum size of 8 characters seems to be hard-coded in this line.

mvlassis commented 1 month ago

@lucabello I created #183 that introduces the changes you made (to trigger the CI because it only triggers for team members of the repo).

Great work!

mvlassis commented 1 month ago

@lucabello Since all the CI passes, it's ready to go! Some small suggestions before we merge:

Update the PR title and description to be slightly more descriptive (#183 has some information)
Merge the latest changes from main into the branch

Thanks again!

lucabello commented 1 month ago

Seems like you have your other PR up so not sure if you still need this one, but updating the things you asked nonetheless :)

mvlassis commented 1 month ago

@lucabello I created the PR just to trigger the CI, so I just merged yours and closed #183 as a duplicate.

Thanks for contributing :)