search

canonical / minio-operator

MinIO Operator
Apache License 2.0
2 stars 11 forks source link

fix: remove minimum size requirements #97

Closed i-chvets closed 1 year ago

i-chvets commented 1 year ago

https://github.com/canonical/minio-operator/issues/78

Summary of changes:

NOTE: Extra changes (in addition to one in metadata.yaml) are required to have update libraries and test operator framework.

ca-scribner commented 1 year ago

What is the behaviour when there is no minimum size set? Is it that there is no storage created, or that it just uses some juju default?

I wonder if the best fix to #78 would be to remove the storage entirely. Is that what happens here?

i-chvets commented 1 year ago

@ca-scribner

Storage is optional. No default minimum size is defined, as far as I can see. Charm is using /data directory as specified by storage, so I don't think it is safe to completely remove.

ca-scribner commented 1 year ago

If we cannot remove the storage entirely, what happens when we just omit the minimum size? What size volume is being created? I'm partly worried that, by not setting 10GB as the minimum, we're actually getting a larger volume

i-chvets commented 1 year ago

Looks like without minimum set, PVC is 1G: minio-data-f8ff2d4c-minio-0 Bound pvc-955d1a2b-7702-45d8-a5c5-3549adee5702 1Gi RWO microk8s-hostpath