canonical / mir-ci

Mir CI helpers
1 stars 1 forks source link

mir_ci: reorganize project #103

Closed Saviq closed 6 months ago

Saviq commented 6 months ago

Place things into a more sane structure:

├── mir_ci
│   ├── fixtures
│   ├── interfaces
│   ├── lib
│   ├── program
│   ├── tests
│   │   ├── clients
│   │   ├── data
│   │   └── robot
│   │       ├── libraries
│   │       ├── resources
│   │       └── templates
│   └── wayland
│       └── data
└── tools

Normally tests would live outside the Python package, but we actually want them installed.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.19%. Comparing base (bedc74d) to head (437b5e2). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== + Coverage 63.88% 65.19% +1.31% ========================================== Files 11 14 +3 Lines 742 770 +28 Branches 103 103 ========================================== + Hits 474 502 +28 Misses 243 243 Partials 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Saviq commented 6 months ago

I'm of two minds about the lib folder. Both Cgroup and Benchmarker could, arguably, live under program

But I'll split out Screencopy out from ScreencopyTracker, and then the tracker would have a place under lib

mattkae commented 6 months ago

I'm of two minds about the lib folder. Both Cgroup and Benchmarker could, arguably, live under program

But I'll split out Screencopy out from ScreencopyTracker, and then the tracker would have a place under lib

What is supposed to be the distinction between lib and program here?

Saviq commented 6 months ago

I wonder if screencopy.resource should be renamed to something else. Maybe keywords.resource? It started as a resource file for the Screencopy library, but now it's also about WaylandHid.

Indeed, will come up with something.

What is supposed to be the distinction between lib and program here?

program would be about running things, not necessarily in testing context; lib about tracking… I suppose Cgroup should go into program actually.

Saviq commented 6 months ago

I wonder if screencopy.resource should be renamed to something else. Maybe keywords.resource? It started as a resource file for the Screencopy library, but now it's also about WaylandHid.

I'm starting to think KVM, as in Keyboard, Video, Mouse… but would also gladly accept something else…

hbatagelo commented 6 months ago

KVM sounds good!