canonical / mir-ci

Mir CI helpers
1 stars 1 forks source link

Implement roundtrip to avoid deadlocks #12

Closed wmww closed 1 year ago

wmww commented 1 year ago

I haven't seen any deadlocks with the existing code, but I have seen them with new code I'm writing and I think they're possible with existing code. My theory as to what's going on is display.roundtrip() dispatches, we have our own dispatch thread, and things go poorly when there are multiple dispatcher. Implementing roundtrip ourselves such that it uses our dispatcher fixes this problem.

bors[bot] commented 1 year ago

Build succeeded: