canonical / mir-ci

Mir CI helpers
1 stars 1 forks source link

robot: build a WaylandRobot wrapper #92

Closed Saviq closed 3 months ago

codecov[bot] commented 5 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c7ae89a) 63.88% compared to head (81c0231) 64.22%. Report is 3 commits behind head on main.

Files Patch % Lines
mir-ci/mir_ci/robot_wrapper.py 70.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== + Coverage 63.88% 64.22% +0.34% ========================================== Files 11 12 +1 Lines 742 766 +24 Branches 103 104 +1 ========================================== + Hits 474 492 +18 - Misses 243 249 +6 Partials 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Saviq commented 5 months ago

When I run locally, the dbus-run-session -- python3 fails to open python3, but it seems fine in the CI, so...

Oh that sneaked in, will revert.

hbatagelo commented 5 months ago

It opens without the new session, but the font/decoration is now different. Probably needs more tweaking in the keyfile. Screenshot from 2024-02-09 17-48-01

Saviq commented 5 months ago

It opens without the new session, but the font/decoration is now different. Probably needs more tweaking in the keyfile.

Yeah this app isn't isolated yet - I should do it here to have a better chance of matching. Will improve.