Closed hbatagelo closed 4 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
97766d3
) 64.05% compared to head (baa7e3c
) 63.88%. Report is 12 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
mir-ci/mir_ci/virtual_pointer.py | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yeah, choosing the behavior based on argument types would resolve the issue and keep the keywords concise. However, I'd prefer using strong types instead of differentiating solely between int
and float
.
To keep things simple, perhaps we could just use Move Pointer To [Proportional] point
and Walk Pointer From [Proportional] point_a To [Proportional] point_b
. If the optional [Proportional]
word is not used, it would default to absolute positioning.
I see very little use in these, as there's going to be a limited number of use cases warranting moving to the source without modifying the button states?
True, I was thinking of gestures and multi-step drawing/dragging, but we can always get the destination position from a previous move/walk and use it as the source position for the next command.
I've removed the proportional
optional arguments. Now we have the following keywords which should be enough for most use cases:
Move Pointer to ${destination}
Moves the pointer to an absolute position or image template.
Move Pointer To Proportional ${position}
Moves the pointer to a proportional position.
Walk Pointer From ${start_position} To ${destination}
Walks from an absolute position to an absolute position or template
Walk Pointer From ${start_position} To Proportional ${end_position}
Walks from an absolute position to a proportional position
Fixes #83.
Modified keywords:
Move Pointer To ${destination}
, where${destination}
can be either the name of an image template, or an xy-point.Walk Pointer From ${source} To ${destination}
, where${source}
and${destination}
can be the name of image templates, or points.Examples:
An optional argument,
${proportional}
, can be used to move to a position proportional to the dimensions of the output. For instance, to move to the center of the output:or simply
Examples with
Walk Pointer
:Walk Pointer
hasproportional_source
andproportional_destination
optional arguments:PS. The names
Move Pointer To Proportional
andMove Pointer To Absolute
fromWaylandHid
may be shadowed byMove Pointer
. A solution is to use underscores or the keyword's full name: