search

canonical / mir

The Mir compositor
GNU General Public License v2.0
641 stars 102 forks source link

Firefox on X11 invalid SSD name #1966

Open wmww opened 3 years ago

wmww commented 3 years ago

When I run Firefox in X11 and open a new Github issue, the font rendering seems to be incorrect and Mir's consoled complains of

[2021-03-23 19:07:15.743598] < -warning- > mirserver: Window title New Issue � MirServer/mir — Mozilla Firefox is not valid UTF-8
AlanGriffiths commented 3 years ago

Is this a Mir bug or a Firefox bug? I.e. should the title be a valid UTF-8 string?

wmww commented 3 years ago

My guess is the error message is wrong, and Mir is failing to process valid UTF-8 (considering FF is widely used and these code paths in Mir are hardly tested).

AlanGriffiths commented 3 years ago

Just from switching on MIR_X11_VERBOSE_LOG: It looks like we're ignoring the valid utf8 string in _NET_WM_NAME and processing some non-utf8 text from WM_NAME as though it were utf8.

(But looking at the code I don't see WM_NAME anywhere, so this is probably wrong.)