canonical / mlflow-operator

MLFlow Operators
Apache License 2.0
11 stars 9 forks source link

MLFlow deployment deploys additionally the LB/NodePort #11

Open Barteus opened 2 years ago

Barteus commented 2 years ago

When deploying the MLFlow additional access point to MLFlow is created.

Why do we expose this? Should we not use relations to Istio/pilot and ingress gateway to expose MLFlow, especially since MLFlow is open to the public by default? When used with Charmed Kubeflow the DEX is used to provide the authentication.

In code: https://github.com/canonical/mlflow-operator/blob/4bdda5d0a545821109c380b8d460c69c6d5de9be/charms/mlflow-server/src/charm.py#L216

ca-scribner commented 1 year ago

I think we've treated the mlflow charm as something that could be deployed with kubeflow or standalone, rather than something that had to be with kubeflow. But it would make more sense to have configuration options to only expose what is needed based on the setup chosen