[DPE-5374] Move agnostic upgrade to upgrade_helpers

canonical / mongodb-operator

Charmed solution for MongoDB

Apache License 2.0

12 stars 14 forks source link

[DPE-5374] Move agnostic upgrade to upgrade_helpers #481

Closed Gu1nness closed 2 months ago

Gu1nness commented 2 months ago

Issue

The actual Upgrade class is substrate agnostic and should be reused.
This will allow testing the pre-upgrade checks on mongodb-k8s charm.

Solution

Extract in the upgrade_helpers.

Gu1nness commented 2 months ago

But is it implementation agnostic. i.e. if we go with v3 on MongoDB K8s but v2 on MongoDB VM with this change still stand?

This code does not care about the actual upgrade but only the checks. If V3 needs some update, we can always overload the functions that would need a fix. This only ports the minimal amount of code to make the pre upgrade hooks work :)

MiaAltieri commented 2 months ago

My concern is that functions in AbstractUpgrade won't be used in K8s , since ideally those upgrade specific functions will be in a lib for v3. But I trust you!