search

canonical / mongodb-operator

Charmed solution for MongoDB
Apache License 2.0
12 stars 14 forks source link

Stop patching the private ops.testing._TestingModelBackend class #484

Open tonyandrewmeyer opened 2 months ago

tonyandrewmeyer commented 2 months ago

Steps to reproduce

  1. grep _TestingModelBackend

Expected behavior

No results.

Actual behavior

Results.

Versions

Operating system: N/A

Juju CLI: N/A

Juju agent: N/A

Charm revision: N/A

LXD: N/A

Log output

Juju debug log: N/A

Additional context

As _TestingModelBackend is a private class, no guarantees are made about compatibility, and the tests relying on patching this class will break in an upcoming ops release.

The patching is actually no longer required with recent versions of ops, so mostly the patching can just be removed, with the occasional add_network call potentially required.

You can use these PRs as examples if needed:

If any assistance is required, please reach out to @canonical/charm-tech and we'll be happy to help!

I believe all the changes you require are in this commit but I can't run the unit tests of this charm locally, so am not sure whether I can just open a PR from that.

syncronize-issues-to-jira[bot] commented 2 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5446.

This message was autogenerated