search

canonical / multipass-blueprints

Blueprint definitions for [`multipass launch`](https://multipass.run)
GNU General Public License v3.0
66 stars 38 forks source link

charm-dev updates #14

Closed sed-i closed 2 years ago

sed-i commented 2 years ago
sed-i commented 2 years ago

Works fine, would it make sense to actually preinstall (one of) those tools?

For me personally yes, but to do it properly cross platform would entail go get for k9s or cargo install for kdash, which would noticeably increase deployment times. I would definitely add e.g. k9s if it becomes available via apt.

Saviq commented 2 years ago

@sed-i why the keyring?

And ACK on k9s/dash. Something to solve with a custom image that has these built in.

sed-i commented 2 years ago

@sed-i why the keyring?

Recent versions of charmcraft won't work without it: https://github.com/canonical/charmcraft/issues/719#issuecomment-1087643162

Saviq commented 2 years ago

Recent versions of charmcraft won't work without it: canonical/charmcraft#719 (comment)

Oh, does that mean you now need to run that D-Bus stuff manually to use charmcraft? MEH!

sed-i commented 2 years ago

Oh, does that mean you now need to run that D-Bus stuff manually to use charmcraft? MEH!

Unfortunately, yes. But it works.

sed-i commented 2 years ago

@Saviq is this ok to merge?

Saviq commented 2 years ago

@sed-i yes, I just got my write rights back on this repo, so here goes ;)