search

canonical / multipass-blueprints

Blueprint definitions for [`multipass launch`](https://multipass.run)
GNU General Public License v3.0
68 stars 42 forks source link

Add rockcraft to the docker blueprint #31

Closed sed-i closed 3 months ago

sed-i commented 1 year ago

Tested manually by copying the cloud init part into its own yaml and

multipass launch --cloud-init v1/docker-cloud-config.yaml --name docker-new --mem 4G --cpus 3 --disk 20G
sed-i commented 1 year ago

We could half a blueprint dedicated to rockcraft, but as you say, the only difference from docker bp would probably be just portainer. How about adding rockcraft to the charm-dev blueprint? Would you be ok with that?

townsend2010 commented 1 year ago

Hey @sed-i,

I say if rockcraft is pretty relevant to what's already contained in the charm-dev Blueprint, I'm fine with that. One thing is that the charm-dev Blueprint already does quite a bit of bootstrapping at launch and this will just make it even more heavy. That said, charm-dev is intended for developers, so if they are ok with this, then I am too.

ricab commented 4 months ago

@sed-i, are you OK with closing this now?

ricab commented 3 months ago

Alright, going ahead and closing this. Please reopen if necessary.

sed-i commented 3 months ago

Sorry @ricab, just saw this now. Rockcraft is now part of charm-dev, so solves some set of problems :)

I think more than anything else, the value of this PR was in the iptables commands that let docker coexist with rockcraft. In any case, we can keep this closed.