`transfer` gives no additional context with verbose flag

canonical / multipass

Multipass orchestrates virtual Ubuntu instances

https://multipass.run

GNU General Public License v3.0

7.73k stars 641 forks source link

`transfer` gives no additional context with verbose flag #1841

Open seb128 opened 3 years ago

seb128 commented 3 years ago

Using 1.5.0 (2857) on Ubuntu 20.10 $ multipass launch focal -n lts Launched: lts $ multipass transfer -h ... -v, --verbose Increase logging verbosity. Repeat the 'v' in the short option $ echo "txt" > bug $ multipass transfer -vvv bug lts: $ multipass transfer -vvv bug lts: (trying again to see if it tells about overwriting an existing file for example) $ multipass transfer -vvv bug lts:/home/ubuntu transfer failed: [sftp push] open failed: 'SFTP server: Failure' $ multipass transfer -vvv lts:/home/ubuntu/bug /tmp

Unsure in which cases the verbose option is supposed to print something, or is it simply not working?

Saviq commented 3 years ago

Hi @seb128, it's working fine, just we've no additional logging for this case.

seb128 commented 3 years ago

Alright, I guess the bug could be repurposed in 'please include more details in the verbose log'

Example where there could be more information:

if the target already exists tell that it's going to be overwritten (or not?)
describe the action, 'Going to copy real system /tmp/bla to ubuntu instance /tmp/new'
includes details in the error cases, 'open failed: 'SFTP server: Failure' isn't really informative, the error could be nicer but the verbose mode could also help providing details on what went wrong

amartincolby commented 1 year ago

I would very much appreciate this. I have an issue where a transfer is not overwriting files that were previously transferred and I do not know why.