canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.83k stars 650 forks source link

sshfs mounts does not work when user shell is set to `fish` #3033

Open soredake opened 1 year ago

soredake commented 1 year ago

Describe the bug sshfs mounts does not work when user shell is set to fish.

To Reproduce How, and what happened?

  1. sudo chsh -s /usr/bin/fish $USER

Expected behavior Mounts should work.

Logs mounts.txt

Additional info

Additional context Add any other context about the problem here.

townsend2010 commented 1 year ago

Hi @soredake!

To follow up from the other bug, is this a new bug with the RC and things worked before in 1.11.1?

As an aside, we have made some assumptions (perhaps wrongly) in the commands we pass into the instance which is not working with fish. We should probably explicitly call bash in our commands in order to ensure nothing goes wrong like what you.

soredake commented 1 year ago

To follow up from the other bug, is this a new bug with the RC and things worked before in 1.11.1?

No, sshfs mounts are broken for me in 1.11.1, probably because of fish.

townsend2010 commented 1 year ago

Ok, thanks for confirming. We will work on proper fix to account for different default shells.

Abuelodelanada commented 1 year ago

Hello @soredake @townsend2010

I can say that in (k)Ubuntu 22.10 it's working fine:

➜  ~ multipass info charm-dev-juju-29
Name:           charm-dev-juju-29
State:          Running
IPv4:           192.168.122.105
                10.19.235.1
Release:        Ubuntu 22.04.2 LTS
Image hash:     345fbbb6ec82 (Ubuntu 22.04 LTS)
CPU(s):         3
Load:           4.45 1.27 0.43
Disk usage:     8.6GiB out of 28.9GiB
Memory usage:   966.8MiB out of 3.8GiB
Mounts:         /home/jose/trabajos/canonical/repos => /home/ubuntu/repos
                    UID map: 1000:default
                    GID map: 1000:default

➜  ~ snap info multipass | grep "installed"
installed:          1.12.0-dev.365.pr3009+gb74f2f95            (9171) 120MB -

That VM is running ZSH as a default shell