Closed townsend2010 closed 6 months ago
Hey @sharder996, could you please review this at your earliest convenience? Thanks!
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
dd25b5b
) 84.17% compared to head (205cb0f
) 84.16%. Report is 14 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/daemon/daemon.cpp | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is there an option available to not force pollinate package in merged cloud-init?
I'm not sure if valid use-case... but I think this breaks install of other packages when image deployed via multipass does not have package manager with sources for pollinate.
E.g. deploying alpine imagine with cloud-init, I can define apk packages to install, but now pollinate is added, causing all other packages to fail install.
Hi @mytchh, I am afraid that only ubuntu images are currently supported. To support other images, we would need to generalize this and other things in the code.
This will add the pollinate package to the snapcraft buildd images. It is no-op on the regular cloud images since it already exists.
Fixes #3390