codecov[bot]
commented
6 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6aed68d) 88.56% compared to head (2a3a459) 88.57%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #3400 +/- ## ========================================== + Coverage 88.56% 88.57% +0.01% ========================================== Files 251 251 Lines 13859 13864 +5 ========================================== + Hits 12274 12280 +6 + Misses 1585 1584 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Addresses #3399.
I am not super happy about this approach, as it goes against fail fast, breaking preconditions for other operations (snapshots+resizing) and leaving a VM around in a bad state. A better approach would be to put any VMs whose constructor threw into a special quarantine state, where only a select few operations would be allowed. But we don't have time for that right now and the operation in question is transitory anyway, so I guess this will do.