search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.63k stars 635 forks source link

[snap] Improve snap packaging #3405

Closed townsend2010 closed 6 months ago

townsend2010 commented 6 months ago

This will quiet the errors and linter. The only warning now is for libvirt.so which is still needed since it is dlopen()'d. This reduces the Snap size by ~45%!

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5fae6a5) 88.56% compared to head (1a3633f) 88.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3405 +/- ## ======================================= Coverage 88.56% 88.56% ======================================= Files 251 251 Lines 13864 13864 ======================================= Hits 12279 12279 Misses 1585 1585 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sharder996 commented 6 months ago

@townsend2010, Thanks for replying to all my comments!

townsend2010 commented 6 months ago

Merge queue failure seems to be caused by a random test failure not related to this PR. Trying again.