search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.54k stars 635 forks source link

Snapshot boot commands #3424

Closed luis4a0 closed 3 months ago

luis4a0 commented 4 months ago

This PR adds the ability to snapshot the commands to be run at boot on each instance that the daemon keeps.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.71%. Comparing base (dcc4232) to head (8ec90d1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## snapshot_extra_interfaces #3424 +/- ## ============================================================= + Coverage 88.69% 88.71% +0.01% ============================================================= Files 253 253 Lines 14016 14023 +7 ============================================================= + Hits 12432 12440 +8 + Misses 1584 1583 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

townsend2010 commented 3 months ago

Hi @luis4a0!

I don't remember now, but did we decide not to do this?

luis4a0 commented 3 months ago

Hey @townsend2010! Yes, we decided not to do this, so this was marked as "rejected" in the last pulse. However, we decided to keep the branch in case we need the run_at_boot code at some point. OTOH, we said nothing about this PR.

townsend2010 commented 3 months ago

Hey @luis4a0!

Right, thanks for jogging my memory. :slightly_smiling_face: I will close this PR then and the branch itself will be preserved.