search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.76k stars 642 forks source link

Move new interface configuration to the instance settings handler #3429

Closed luis4a0 closed 6 months ago

luis4a0 commented 7 months ago

The interfaces added with set were added in two stages: one in the instance settings handler, and one at start. This PR moves all the code to the instance settings handler, so there are no half states when snapshotting. It is based on the code to configure interfaces via cloud-init.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.69%. Comparing base (dd17d34) to head (4713203).

Files Patch % Lines
src/daemon/daemon.cpp 90.56% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3429 +/- ## ========================================== + Coverage 88.59% 88.69% +0.09% ========================================== Files 254 254 Lines 14086 14037 -49 ========================================== - Hits 12480 12450 -30 + Misses 1606 1587 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

georgeliao commented 6 months ago

Hi @luis4a0 , thanks for the good work. It looks good to me in general.

I left a few small comments to address. After that, I think we can merge.