search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.54k stars 635 forks source link

Fix coverage on Mantic #3434

Closed luis4a0 closed 3 months ago

luis4a0 commented 4 months ago

The covreport target is not working (this target is obtained by using the CMake flag -DCMAKE_BUILD_TYPE=Coverage) with Mantic. The reason is that the lcov package in Mantic is broken; this is fixed by installing the package from Noble. But this newer package produce some warnings which become fatal. This PR makes newer versions of lcov ignore those warnings, producing the desired output.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.70%. Comparing base (2bf881f) to head (55f7b2e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3434 +/- ## ======================================= Coverage 88.70% 88.70% ======================================= Files 253 253 Lines 14012 14012 ======================================= Hits 12429 12429 Misses 1583 1583 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.