search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.85k stars 650 forks source link

Fix handling of `~` in Blueprint launch from file. #3437

Closed luis4a0 closed 7 months ago

luis4a0 commented 7 months ago

QFileInfo does not expand ~, so we need to do it by hand when necessary.

Fixes #3421.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.60%. Comparing base (dd17d34) to head (214b869).

Files Patch % Lines
src/client/cli/cmd/launch.cpp 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3437 +/- ## ======================================= Coverage 88.59% 88.60% ======================================= Files 254 254 Lines 14086 14088 +2 ======================================= + Hits 12480 12482 +2 Misses 1606 1606 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luis4a0 commented 7 months ago

Right, closing for now. Thanks for your input!