search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.54k stars 635 forks source link

Handle legacy snapshots #3439

Closed luis4a0 closed 2 months ago

luis4a0 commented 4 months ago

Snapshots taken with old versions of Multipass did not store the extra_interfaces field. If an interface is added after instance creation, it will overwrite the extra interfaces added at creation. This PR fixes that behavior.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.90%. Comparing base (697e2f5) to head (19c87d1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3439 +/- ## ======================================= Coverage 88.89% 88.90% ======================================= Files 254 254 Lines 14081 14084 +3 ======================================= + Hits 12517 12521 +4 + Misses 1564 1563 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luis4a0 commented 3 months ago

Great, thanks @ricab! I'll rebase the private branch, there is some Hyper-V code also. Thanks!

townsend2010 commented 3 months ago

This is going to fail the merge queue due to the private side. Please merge manually when ready. :slightly_smiling_face:

ricab commented 2 months ago

Right, done!