search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.54k stars 635 forks source link

Fix non-bridging settings #3449

Closed luis4a0 closed 3 months ago

luis4a0 commented 3 months ago

The code in Daemon::set() did not take into account that Daemon::get_bridged_interface_name() could throw. Throwing is correct in all the other calls, so only the exception thrown in set() was catched this time.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.65%. Comparing base (0270a47) to head (7d654f9). Report is 4 commits behind head on main.

Files Patch % Lines
src/daemon/daemon.cpp 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3449 +/- ## ========================================== - Coverage 88.68% 88.65% -0.04% ========================================== Files 254 254 Lines 14037 14047 +10 ========================================== + Hits 12449 12453 +4 - Misses 1588 1594 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luis4a0 commented 3 months ago

Hey @ricab, thanks for the review! Yes, we can address the user-authorization stuff in a new PR.