search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.52k stars 631 forks source link

[cli] Make the --verbosity option case insensitive #3474

Closed nielsreijers closed 2 months ago

nielsreijers commented 2 months ago

Fixes #3467

sharder996 commented 2 months ago

@nielsreijers Have you had a chance to sign the Canonical cla?

https://ubuntu.com/legal/contributors

nielsreijers commented 2 months ago

@nielsreijers Have you had a chance to sign the Canonical cla?

https://ubuntu.com/legal/contributors

Ah, I didn't think that was required since my last PR got merged without it. I'm happy to sign it of course and was just about to do so, but it's asking me for a "Canonical Project Manager or contact"... Any idea what I should fill in there?

townsend2010 commented 2 months ago

Hi @nielsreijers,

I'm going to jump in here about the CLA :slightly_smiling_face:

So, the CLA allows for not having to be signed for very small contributions, such as yours with the one line change to the control file. However, if your proposed change is more than a line or two, then the CLA will need to be signed. You can put me down as the contact: Chris Townsend christopher.townsend@canonical.com

Once you have signed it, just let us know here that you did and we can proceed. Thank you for your contributions!

nielsreijers commented 2 months ago

Hi @nielsreijers,

I'm going to jump in here about the CLA 🙂

So, the CLA allows for not having to be signed for very small contributions, such as yours with the one line change to the control file. However, if your proposed change is more than a line or two, then the CLA will need to be signed. You can put me down as the contact: Chris Townsend christopher.townsend@canonical.com

Once you have signed it, just let us know here that you did and we can proceed. Thank you for your contributions!

Thanks Chris, I just singed the CLA :-)

nielsreijers commented 2 months ago

Hi @nielsreijers, I'm going to jump in here about the CLA 🙂 So, the CLA allows for not having to be signed for very small contributions, such as yours with the one line change to the control file. However, if your proposed change is more than a line or two, then the CLA will need to be signed. You can put me down as the contact: Chris Townsend christopher.townsend@canonical.com Once you have signed it, just let us know here that you did and we can proceed. Thank you for your contributions!

Thanks Chris, I just singed the CLA :-)

Hmm, not sure why it's still failing... I did see the "Thank you" message saying I signed the CLA... Is it because the first time I filled in my email as the launchpad id? I just filled it in again with nielsreijers as my username, maybe that helps?

sharder996 commented 2 months ago

Hi @nielsreijers, I'm going to jump in here about the CLA 🙂 So, the CLA allows for not having to be signed for very small contributions, such as yours with the one line change to the control file. However, if your proposed change is more than a line or two, then the CLA will need to be signed. You can put me down as the contact: Chris Townsend christopher.townsend@canonical.com Once you have signed it, just let us know here that you did and we can proceed. Thank you for your contributions!

Thanks Chris, I just singed the CLA :-)

Hmm, not sure why it's still failing... I did see the "Thank you" message saying I signed the CLA... Is it because the first time I filled in my email as the launchpad id? I just filled it in again with nielsreijers as my username, maybe that helps?

The Github action for checking the CLA is broken at the moment, but your confirmation that you have signed it is good enough right now.