Closed nielsreijers closed 2 months ago
Hi @nielsreijers, AFAIK tags are not automatically forked. I think the correct solution would be to document the command to fetch the tags to the build document. We'll take care of that soon. Thanks for reporting!
Description of documentation issue or suggestion I made a fork of multipass and tried to build it using the instructions in the README.md. This failed on the
cmake ../
step because forking the repository doesn't copy tags.The issue is in the root CMakeLists.txt which contains the following lines
Since the forked repo has no tags,
git describe --long
doesn't return anything, and we get an error on line 156:Proposal to fix issue or enact suggestion Forking a repository and trying to build it seems like a common case, so I think it should be possible (without debugging the build process), but there could be two ways to support it:
git fetch --tags https://github.com/canonical/multipass.git
seems sufficient to pull the upstream tags into the forked repository, so the "Building" section in README.md could be expanded with something like:multipass --version
.Additional context I could send a PR for either, but would like to know the maintainers preferred approach would be here.