canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.52k stars 631 forks source link

[snap] Add curl build dependency #3481

Closed townsend2010 closed 2 months ago

townsend2010 commented 2 months ago

This is needed for vcpkg support and the Launchpad builders don't have it installed by default.

Fixes #3480

townsend2010 commented 2 months ago

I will have to see how to try this out before actually committing it to main.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.89%. Comparing base (1affcb3) to head (56c0a46).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3481 +/- ## ======================================= Coverage 88.89% 88.89% ======================================= Files 254 254 Lines 14081 14081 ======================================= Hits 12517 12517 Misses 1564 1564 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

townsend2010 commented 2 months ago

Here is a good build using the Launchpad builders: https://launchpad.net/~townsend/+snap/multipass-test-lp-build/+build/2448716

So this works! :tada: