search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.52k stars 631 forks source link

Fix failing snap builds on launchpad #3495

Closed townsend2010 closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.89%. Comparing base (19f8477) to head (a1bbbab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3495 +/- ## ======================================= Coverage 88.89% 88.89% ======================================= Files 254 254 Lines 14084 14084 ======================================= Hits 12520 12520 Misses 1564 1564 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sharder996 commented 2 months ago

Does this use cmake v3.29.2 now?

townsend2010 commented 2 months ago

Hey @sharder996!

Does this use cmake v3.29.2 now?

Yes, for building the snap.

sharder996 commented 2 months ago

Hey @sharder996!

Does this use cmake v3.29.2 now?

Yes, for building the snap.

And, the issue we were having with v3.29.1 is fixed in the patch?

townsend2010 commented 2 months ago

And, the issue we were having with v3.29.1 is fixed in the patch?

Yes, 3.29.2 reverted the "issue" introduced in 3.29.1. Please see https://github.com/Kitware/CMake/commit/df6b2a3d7d9f2be54234915b3b663dd6783cd575.

townsend2010 commented 2 months ago

Try again...