canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.51k stars 632 forks source link

[build] Add rc versioning when creating packages #3516

Closed townsend2010 closed 2 months ago

georgeliao commented 2 months ago

It looks good, a more specific match is definitely better in this scenario. I will wait for the build to finish before I merge.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.82%. Comparing base (71d73f3) to head (6fcb30a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3516 +/- ## ======================================= Coverage 88.82% 88.82% ======================================= Files 254 254 Lines 14115 14115 ======================================= Hits 12538 12538 Misses 1577 1577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

townsend2010 commented 2 months ago

Hey @georgeliao! This is all green now CI. Could you please approve and add to the merge queue at your convenience? Thanks!

townsend2010 commented 2 months ago

Ok, due to CI issues on macOS, I'm just going to merge this manually.