Closed ricab closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.85%. Comparing base (
62c4fc6
) to head (06b6b8f
). Report is 28 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR improves error handling around writing files via
make_file_with_content()
.There are actually two versions of
make_file_with_content()
before this PR: one in utils, one in tests. One started as a copy-paste of the other, then they drifter apart. Entropy always increases... That is fixed here (not entropy increasing unfortunately).But what prompted this was this failure. That might arise if the test file is not properly flushed when closed, as that error would go undetected. This refines the implementation of
make_file_with_content
by callingQFile::flush()
directly and checking the return. It also adds more details whenQFile
detects an error.One further improvement is left for another occasion.