search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.7k stars 638 forks source link

Accept local.driver values regardless of the case #3565

Closed ricab closed 2 days ago

ricab commented 2 months ago

For instance, multipass set local.driver=VirtualBox should work as well as multipass set local.driver=virtualbox. Also, we should probably accept "Hyper-V"/"hyper-v" along with "hyperv".

levkropp commented 2 weeks ago

Also, we should probably accept "Hyper-V"/"hyper-v" along with "hyperv".

I think we should remove dashes, slashes, and generally any non-alphanumeric characters from being read as well.

multipass set local.driver=VirtualBox should work as well as multipass set local.driver=virtualbox

What do you think about allowing "vbox"?

ricab commented 2 weeks ago

I agree with removing the dashes, not so sure about slashes and other characters. "vbox" sounds reasonable to me too.

levkropp commented 2 weeks ago

On second thought, supporting "vbox" adds more complexity than it is worth and there is no official source that uses "vbox" or similar as an alias for VirtualBox anyways