search

canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.79k stars 643 forks source link

New GUI doesn't respect theme #3608

Open DiogoConstantino opened 2 months ago

DiogoConstantino commented 2 months ago

New GUI doesn't respect theme, when using Yaru Dark

How, and what happened?

  1. set yaru dark theme on Ubuntu
  2. use the new GUI for Multipass

Expected behavior It should have respected the Yaru Dark Theme, however it doesn't and the main part of the window has a white background.

Logs Can't see anything on the logs by running: "journalctl --unit 'snap.multipass*'" as sugest on the documentation, so if there's another log that is relevant please ask me for it

Additional info

Additional context This is a screenshot of the app as rendered to me: image

andrei-toterman commented 2 months ago

Hey, @DiogoConstantino! Thanks for reporting this. Indeed, as of now, the GUI does not have a dark mode implemented, but I agree it would be a nice feature. It's not a high priority at the moment, but we'll get to it eventually :)

NemB0t commented 3 weeks ago

Hello @andrei-toterman,

I would like to work on this issue. This will be my first time contributing to this project so would apprecieate some good pointers.

Thanks!

andrei-toterman commented 3 weeks ago

Hey, @NemB0t! That is highly appreciated! The main thing that is holding us back at the moment is that we do not have a good design of how the GUI should look with a dark theme. That is something we'd need to discuss with our designer. So if you're okay with waiting some time before we can get to the implementation, that would be great. I'll let you know as soon as we have a design for that, but I can't give an approximation of how long that would take, given other priorities. Is that okay with you?

NemB0t commented 3 weeks ago

Hey, @andrei-toterman, understandable, please let me know once the design is finalized.