Open andrei-toterman opened 2 months ago
Hi @andrei-toterman did anyone take this up. If not then I'll take this up. For creating a testing environment is readme enough or do I require something more.
Hey, @Jainuine! You can take it up if you want :) Yes, just following the readme should be enough for being able to build Multipass, but if you have any issues or you need some clarifications for the task, let me know!
At this moment, when we compile our fork of libssh, we bypass the main CMakeLists.txt file of libssh, in order to avoid some supposedly unnecessary checks. But that CMake file also has some code that is responsible for setting up symbol versioning for the library. Symbol versioning would be useful as an alternative to this fix #3559, since the Qt Network library would be able to use our own libssh. So, in order to compile libssh with symbol versioning, 3 things must be done:
CMAKE_SOURCE_DIR
. Since we include libssh into our project,CMAKE_SOURCE_DIR
will have the value of our own top level project directory, which messes with the logic of the libssh CMake file. We could patch it to useCMAKE_CURRENT_SOURCE_DIR
orPROJECT_SOURCE_DIR
. Or perhaps there are some other alternatives that do not involve touching the libssh CMake file.abimap
available.abimap
is a python package that is used by the libssh CMake code when setting up symbol versioning. It can be installed usingpip install abimap
. But this will probably necessitate setting up a virtual environment for python in which to install that package, or some other way of providing that package without having it installed globally on the machine.