canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.94k stars 654 forks source link

Compile libssh with symbol versioning #3665

Open andrei-toterman opened 2 months ago

andrei-toterman commented 2 months ago

At this moment, when we compile our fork of libssh, we bypass the main CMakeLists.txt file of libssh, in order to avoid some supposedly unnecessary checks. But that CMake file also has some code that is responsible for setting up symbol versioning for the library. Symbol versioning would be useful as an alternative to this fix #3559, since the Qt Network library would be able to use our own libssh. So, in order to compile libssh with symbol versioning, 3 things must be done:

Jainuine commented 4 weeks ago

Hi @andrei-toterman did anyone take this up. If not then I'll take this up. For creating a testing environment is readme enough or do I require something more.

andrei-toterman commented 4 weeks ago

Hey, @Jainuine! You can take it up if you want :) Yes, just following the readme should be enough for being able to build Multipass, but if you have any issues or you need some clarifications for the task, let me know!