canonical / multipass

Multipass orchestrates virtual Ubuntu instances
https://multipass.run
GNU General Public License v3.0
7.76k stars 642 forks source link

[network] Force https usage #3704

Open Sploder12 opened 6 days ago

Sploder12 commented 6 days ago

Converts all http requests to https to help ensure image and checksum validity

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (dd7cfb0) to head (5c0281b). Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/network/url_downloader.cpp 81.81% 2 Missing :warning:
src/platform/backends/lxd/lxd_request.cpp 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3704 +/- ## ========================================== - Coverage 88.94% 88.88% -0.07% ========================================== Files 254 254 Lines 14276 14284 +8 ========================================== - Hits 12698 12696 -2 - Misses 1578 1588 +10 ``` | [Flag](https://app.codecov.io/gh/canonical/multipass/pull/3704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/canonical/multipass/pull/3704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `88.88% <76.92%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.