search

canonical / mysql-k8s-operator

A Charmed Operator for running MySQL on Kubernetes
https://charmhub.io/mysql-k8s
Apache License 2.0
8 stars 15 forks source link

DPE-2397 allow deployment on older then 2.9.44 juju controllers #308

Closed paulomach closed 11 months ago

paulomach commented 1 year ago

Issue

pebble bundled with controllers older then 2.9.44 does not support kill-delay

Solution

Enable kill-delay only if current controller supports it

NOTE: juju does check the assumes on the refresh - so this wont upgrade on a <2.9.44 controller.

carlcsaposs-canonical commented 1 year ago

are we supporting controllers < 2.9.44? https://github.com/canonical/mysql-k8s-operator/blob/d73010c9eba7641a80b6b91982d468eaaba91a47/metadata.yaml#L78

TBF, this may be completely uncessary

taurus-forever commented 1 year ago

are we supporting controllers < 2.9.44?

https://github.com/canonical/mysql-k8s-operator/blob/d73010c9eba7641a80b6b91982d468eaaba91a47/metadata.yaml#L78

TBF, this may be completely uncessary

We never tried on Juju <2.9.29. It doesn't harm here but declares supported limits. @paulomach please update it here https://charmhub.io/mysql-k8s/docs/r-requirements after merging!

carlcsaposs-canonical commented 1 year ago

@taurus-forever Do we need to support juju < 2.9.44? If not, maybe it'd make more sense to close this PR and keep assumes at >=2.9.44

paulomach commented 1 year ago

are we supporting controllers < 2.9.44? https://github.com/canonical/mysql-k8s-operator/blob/d73010c9eba7641a80b6b91982d468eaaba91a47/metadata.yaml#L78

TBF, this may be completely uncessary

We never tried on Juju <2.9.29. It doesn't harm here but declares supported limits. @paulomach please update it here https://charmhub.io/mysql-k8s/docs/r-requirements after merging!

Yes. IIRC, we must settle to something newer due teardown issues. I'll get back to this later

paulomach commented 11 months ago

Close as it's not really necessary