search

canonical / mysql-k8s-operator

A Charmed Operator for running MySQL on Kubernetes
https://charmhub.io/mysql-k8s
Apache License 2.0
8 stars 15 forks source link

tests: limit tenacity to 8.3 or earlier #443

Open tonyandrewmeyer opened 2 weeks ago

tonyandrewmeyer commented 2 weeks ago

Issue

Tests do not pass with tenacity 8.4

Solution

Pin to < 8.4 (I assume you'll want to figure out what needs to be done to support 8.4, but for now this gets things to pass if re-locking).

Workaround for #442.

dimaqq commented 2 weeks ago

Judging by the changes, the content is:

The repo maintainer may or may not want the re-lock because that bumps up a whole bunch of packages, though typically only micro bumps.

P.S. given that old version restriction was ^8.2.2, maybe a more precise version spec can be done, like >=8.2.2,<8.4 ?

The @paulomach should decide 🙇🏻

carlcsaposs-canonical commented 2 weeks ago

The repo maintainer may or may not want the re-lock because that bumps up a whole bunch of packages

yes, please re-lock by checking out poetry.lock from main and running tox run -e format or poetry lock --no-update

we'll update other dependencies in our renovate PRs

carlcsaposs-canonical commented 2 weeks ago

reverted updates of unrelated packages & added back version floor to range in 5e8bec4f24e77f9a75fdbc0cf52514858a21022c

carlcsaposs-canonical commented 2 weeks ago

updated PR description to remove "fixes" on issue so that original issue stays open (so we fix our unit tests & remove the upper pin)