search

canonical / mysql-operator

Machine charm for MySQL following the operator framework
https://charmhub.io/mysql
Apache License 2.0
7 stars 10 forks source link

DPE-2618 broken after restart #381

Closed paulomach closed 7 months ago

paulomach commented 8 months ago

Issue

Solution

Chore

Closes #380

codecov[bot] commented 8 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e067c41) 65.78% compared to head (8f59687) 65.75%.

Files Patch % Lines
src/charm.py 36.36% 6 Missing and 1 partial :warning:
src/relations/db_router.py 60.00% 1 Missing and 1 partial :warning:
src/relations/mysql_provider.py 60.00% 1 Missing and 1 partial :warning:
src/relations/shared_db.py 60.00% 1 Missing and 1 partial :warning:
src/mysql_vm_helpers.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #381 +/- ## ========================================== - Coverage 65.78% 65.75% -0.04% ========================================== Files 17 17 Lines 3130 3130 Branches 412 417 +5 ========================================== - Hits 2059 2058 -1 + Misses 943 940 -3 - Partials 128 132 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carlcsaposs-canonical commented 7 months ago

re upgrade to 8.0.35: https://github.com/canonical/mysql-operator/pull/382#issuecomment-1900292430

paulomach commented 7 months ago

is the 1439 line change in poetry.lock intentional?

necessary after updating ops apparently

carlcsaposs-canonical commented 7 months ago

is the 1439 line change in poetry.lock intentional?

necessary after updating ops apparently

if I checkout poetry.lock from main and run poetry lock --no-update, there's a significant diff with current branch

I think poetry lock without --no-update might've been run, was wondering if that was intentional

paulomach commented 7 months ago

is the 1439 line change in poetry.lock intentional?

necessary after updating ops apparently

if I checkout poetry.lock from main and run poetry lock --no-update, there's a significant diff with current branch

I think poetry lock without --no-update might've been run, was wondering if that was intentional

have you tried to do it with updated ops? I'm using tox -e format to update the lock file - retried to the same results locally

carlcsaposs-canonical commented 7 months ago

have you tried to do it with updated ops? I'm using tox -e format to update the lock file - retried to the same results locally

yes

git checkout origin/main -- poetry.lock
tox run -e format
paulomach commented 7 months ago

have you tried to do it with updated ops? I'm using tox -e format to update the lock file - retried to the same results locally

yes

git checkout origin/main -- poetry.lock
tox run -e format

Oh, it was due a merge conflict resolution. fixed on 99ba985