Closed lucasgameiroborges closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.43%. Comparing base (
76825fa
) to head (591e79c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I see the check libraries
test failing in every commit, including in other PRs. Is this expected?
I see the
check libraries
test failing in every commit, including in other PRs. Is this expected?
I think it's expected, since there are other outdated charm libraries.
Any feedback is appreciated! tox run -e build-wrapper && mv requirements-last-build.txt requirements.txt && charmcraft pack
would recommend pipx install charmcraftcache
and tox run -e build-dev
instead
(from https://github.com/canonical/mysql-operator/blob/main/CONTRIBUTING.md#developing)
I think I'll go ahead and merge it, then. Thanks everyone!
Issue
Missing snap aliases (ie using instead of charmed-msql.) for better tool usability inside VM.
Solution
Heavily inspired by ticket DPE-2090.
Testing
Since it is my first PR, here's how I went about testing my changes. Any feedback is appreciated!
With output: