search

canonical / mysql-operator

Machine charm for MySQL following the operator framework
https://charmhub.io/mysql
Apache License 2.0
7 stars 10 forks source link

[DPE-3705, DPE-3542] Reintroduce fallback keys and fix TLS secrets initialization #427

Closed shayancanonical closed 4 months ago

shayancanonical commented 5 months ago

Issue

  1. We are not correctly initializing some TLS secret keys (e.g. cert instead of certificate, cauth instead of certificate-authority)
  2. As part of PR 385, we got rid of the secret fallback keys. However, this is necessary for clients who are upgrading from old versions of the charm (without secrets) to this version of the charm (with secrets)

Solution

  1. Correctly initialize the TLS secret keys
  2. Re-introduce fallback keys in the framework of the new secrets lib (data_interfaces) (see Jira ticket for link to conversation for more context)
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (2bd2bcc) to head (9126174). Report is 2 commits behind head on main.

Files Patch % Lines
lib/charms/mysql/v0/mysql.py 59.09% 5 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #427 +/- ## ========================================== - Coverage 66.39% 66.25% -0.14% ========================================== Files 17 17 Lines 3169 3180 +11 Branches 419 424 +5 ========================================== + Hits 2104 2107 +3 - Misses 930 935 +5 - Partials 135 138 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shayancanonical commented 5 months ago

Updated libpatch in 9cddb26

I tried testing upgrades from previous stable versions:

carlcsaposs-canonical commented 5 months ago
  • The revision for when upgrades feature was merged is no longer accessible in CI due to expired logs

it's available from releases page (e.g. https://github.com/canonical/mysql-operator/releases?q=292&expanded=true) also available as git tag on that commit