search

canonical / mysql-operator

Machine charm for MySQL following the operator framework
https://charmhub.io/mysql
Apache License 2.0
7 stars 10 forks source link

[DPE-3824] Upgrade mysqld-exporter to v0.15 #430

Closed shayancanonical closed 4 months ago

shayancanonical commented 4 months ago

Issue

We would like to test a new build of the charmed-mysql-snap which contains an upgraded version of mysqld-exporter

Solution

Update snap revision to reflect the new build

TODO

Update charm revision to 8.0/edge revision after https://github.com/canonical/charmed-mysql-snap/pull/45 is merged in

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.39%. Comparing base (bf48660) to head (2f3d73e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #430 +/- ## ======================================= Coverage 66.39% 66.39% ======================================= Files 17 17 Lines 3169 3169 Branches 419 419 ======================================= Hits 2104 2104 Misses 930 930 Partials 135 135 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shayancanonical commented 4 months ago

Closing as PR is irrelevant right now - mysqld-exporter has the following issues https://github.com/prometheus/mysqld_exporter/issues/754 that we are running into

  1. mysqld-exporter 0.15 does not correctly parse unix sockets as --mysqld.address (it expects host:port)
  2. mysqld-exporter 0.15 expects my.cnf style file with args even though it should be optional if the args are passed in through the command line