search

canonical / mysql-router-k8s-operator

Mysql router operator charm for kubernetes
https://charmhub.io/mysql-router-k8s
Apache License 2.0
2 stars 6 forks source link

Update ops to v2.14 #273

Open carlcsaposs-canonical opened 2 months ago

carlcsaposs-canonical commented 2 months ago

Workaround for breaking change in ops 2.10: https://github.com/canonical/operator/pull/1091#issuecomment-1888644075

Workaround may break during deferred ops events or collect status ops events (https://github.com/canonical/operator/pull/1091#issuecomment-2191460188)

carlcsaposs-canonical commented 2 months ago

this charm shouldn't be affected, right?

as currently written, yes (we don't use collect status or deferred events) libs might be affected if they use custom events, but I don't think any custom events are emitted on relation broken

but this change in ops will prevent this charm from using deferred or custom events in the future

taurus-forever commented 1 month ago

@paulomach what is our pissition here? Renovate pushes us to ops 2.15 (security update)... but we need to make decision here first AFAIK.