search

canonical / mysql-router-operator

Mysql router operator charm
https://charmhub.io/mysql-router?channel=dpe/edge
Apache License 2.0
3 stars 3 forks source link

`upgrade_unit` does match signature of abstract method #139

Closed carlcsaposs-canonical closed 3 months ago

carlcsaposs-canonical commented 4 months ago

Mismatch between upgrade_unit call in abstract_charm.py (type hinting is for abstract upgrade.py) https://github.com/canonical/mysql-router-operator/blob/b27eafef502c1286b299c107fc4e68b99e74d0d8/src/abstract_charm.py#L273-L278

upgrade.py abstract upgrade_unit https://github.com/canonical/mysql-router-operator/blob/b27eafef502c1286b299c107fc4e68b99e74d0d8/src/upgrade.py#L231-L236

machine_upgrade.py upgrade_unit https://github.com/canonical/mysql-router-operator/blob/b27eafef502c1286b299c107fc4e68b99e74d0d8/src/machine_upgrade.py#L161-L168

github-actions[bot] commented 4 months ago

https://warthogs.atlassian.net/browse/DPE-4219

carlcsaposs-canonical commented 4 months ago

@shayancanonical FYI; changed in #119

shayancanonical commented 3 months ago

resolved in https://github.com/canonical/mysql-router-operator/pull/135