canonical / mysql-router-operator

Mysql router operator charm
https://charmhub.io/mysql-router?channel=dpe/edge
Apache License 2.0
3 stars 3 forks source link

[DPE-4614] Add support for tracing through tempo-k8s #149

Closed shayancanonical closed 3 months ago

shayancanonical commented 3 months ago

Issue

We would like to be able to instrument our charm and generate traces to discover inefficiencies in charm code execution. The observability team has developed a charm for tempo that we would like to integrate with.

Solution

Integrate with the tempo charm

Considerations

  1. We are not supporting sending traces to tempo-k8s using HTTPS are there are still some rough edges to be rounded with this integration
  2. We need to use the edge version of cos-lite until they release to stable as it contains some critical fixes

image

shayancanonical commented 3 months ago
carlcsaposs-canonical commented 3 months ago

tempo is not meant to be used in production -- it is meant to be used locally to determine why some hook may take a long time to run

when I discussed this with @PietroPasotti a few months ago, my understanding was that this was meant to be used in production—has that changed?

if it's not meant to be used in production, should we merge to main?

shayancanonical commented 3 months ago

charm tracing is not expected to be enabled in production as i understand it, but i still think that there is value in pulling a charm from one of our tracks in a non-prod env and instrument tracing. the tracing integration is an optional one, and does not add any issues if not related to tempo