Match port names across ingress related objects

weiiwang01 commented 12 months ago

Certain versions of the Nginx ingress controller are unable to resolve the endpoints of a service when the port names in the service definition and endpoints definition differ. To address this, update the charm to ensure the port names align across all ingress related objects.

weiiwang01 commented 12 months ago

Do you plan to add some unit tests?

Added, thanks!

github-actions[bot] commented 12 months ago

Test coverage for bbe3f20d3a68369f5d2d09e6d39fbf54b8bbc821

Name                        Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------
src/charm.py                  118      2     20      1    98%   145, 152
src/consts.py                   3      0      0      0   100%
src/controller.py             259     14     69      8    91%   65, 231, 396, 420, 442, 462, 500, 618, 638-639, 807->818, 811-813, 816-817
src/exceptions.py               4      0      0      0   100%
src/ingress_definition.py     254     26     65      8    89%   35, 51, 147-151, 169, 273-274, 319, 331, 335, 351-352, 367-368, 393, 395, 420-421, 454-455, 462-464, 466
-----------------------------------------------------------------------
TOTAL                         638     42    154     17    92%

Static code analysis report

Run started:2023-10-31 12:09:08.396677

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 2723
    Total lines skipped (#nosec): 2
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):

canonical / nginx-ingress-integrator-operator

Match port names across ingress related objects #100