canonical / nginx-ingress-integrator-operator

nginx-ingress-integrator-operator - charm repository.
Apache License 2.0
1 stars 8 forks source link

fix: lib lint type hints, update license year #108

Closed yanksyoon closed 9 months ago

yanksyoon commented 9 months ago

Applicable spec: N/A

Overview

Type hint the lib to pass linting.

Rationale

Pass linting tests.

Juju Events Changes

None.

Module Changes

None.

Library Changes

Added type hint.

Checklist

github-actions[bot] commented 9 months ago

Test coverage for 694316f9f3b6665820f18f7cd13d3c971fe876b9

Name             Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------
src/charm.py       473     30    188      6    93%   417->419, 547, 632-634, 638-643, 651-652, 660-661, 669-674, 693-695, 796-805, 819->844, 1079-1083, 1139, 1182->1218, 1200
src/helpers.py      10      0      2      0   100%
------------------------------------------------------------
TOTAL              483     30    190      6    93%

Static code analysis report

Run started:2024-01-19 14:10:21.365264

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 3871
    Total lines skipped (#nosec): 2
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):