search

canonical / nginx-ingress-integrator-operator

nginx-ingress-integrator-operator - charm repository.
Apache License 2.0
1 stars 8 forks source link

Add support for enable-access-log #111

Closed alnvdl-work closed 6 months ago

alnvdl-work commented 8 months ago

Enhancement Proposal

For charms of applications that generate a lot of logs, disabling access logs with enable-access-log: false helps save significant amounts of storage. This is especially relevant if the application is already logging the requests it's receiving. We have some examples of this internally in Canonical.

weiiwang01 commented 8 months ago

I think this option is for the ingress controller and it will disable logging for the entire ingress controller? If so, I think this might be better managed by the cluster system administrator rather than being managed at the charm level.

alnvdl-work commented 8 months ago

@weiiwang01 No, this request is about enable-access-log, which acts on the ingress level, as an annotation: https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#enable-access-log

For the controller-wide setting, you have a different and very confusingly-named alternative called disable-access-log: https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#disable-access-log

weiiwang01 commented 8 months ago

@alnvdl-work that's right, sorry I misread the configuration. I agree this is a very good addition to the nginx-ingress-integrator!

alnvdl-work commented 7 months ago

@weiiwang01 Is there a timeline for this being available? We depend on this for deploying some of our services that receive a lot of traffic.

weiiwang01 commented 7 months ago

@weiiwang01 Is there a timeline for this being available? We depend on this for deploying some of our services that receive a lot of traffic.

@alnvdl-work Sorry, I have added it in this pull request: https://github.com/canonical/nginx-ingress-integrator-operator/pull/121 I will make it merged and released soon.

weiiwang01 commented 6 months ago

Revision 91 released adding the option enable-access-log.